◐ Shell
clean mode source ↗

[3.11] gh-99357: Close the event loop when it is no longer used in test_uncancel_structured_blocks (GH-99414) by miss-islington · Pull Request #99424 · python/cpython

…t_uncancel_structured_blocks (pythonGH-99414)

(cherry picked from commit 99972dc)

Co-authored-by: Xiao Chen <chenxiao_7@163.com>

@gvanrossum

I'm seeing if the Windows test failure in test_asyncgen was a fluke or repeats itself.

@gvanrossum

Unfortunately it keeps failing on Windows, AFAICT in test_asyncio. Maybe closing the loop triggers something funky? Maybe we need to wait for certain events to occur? I guess ProactorEventLoop behaves sufficiently differently that we cannot rule this out. @kumaraditya303

@kumaraditya303

Unfortunately it keeps failing on Windows, AFAICT in test_asyncio. Maybe closing the loop triggers something funky? Maybe we need to wait for certain events to occur? I guess ProactorEventLoop behaves sufficiently differently that we cannot rule this out.

See #98219, it isn't related to this PR. I am unable to reproduce on Windows 11 so maybe this only happens on Windows Server versions or slow machines.

@gvanrossum

Sadly I cannot merge this with that test failing. I'll try running all the tests one more time, after that I'll invoke the RM.