Update instructions for building on macOS by cesarcoatl · Pull Request #1052 · python/devguide
This looks good from my side, except that as mentioned previously, the immediately following introductory text (the last make step and the first line for MacPorts after it) should be updated to make sense with the changes here and ensure it is clearer for readers which instructions are specific to which distributor and Python version.
I can't make them as suggestions, but I can either just push a commit directly to your branch, or you can apply this diff:
``git diff`` output
diff --git a/getting-started/setup-building.rst b/getting-started/setup-building.rst index b285a74..15e094a 100644 --- a/getting-started/setup-building.rst +++ b/getting-started/setup-building.rst @@ -419,7 +419,7 @@ For example, with **Homebrew**, install the dependencies:: $ brew install pkg-config openssl@1.1 xz gdbm tcl-tk -Then, for Python 3.10 and newer:: +Then, for Python 3.10 and newer, run ``configure``:: $ CFLAGS="-I$(brew --prefix gdbm)/include -I$(brew --prefix xz)/include" \ LDFLAGS="-L$(brew --prefix gdbm)/lib -I$(brew --prefix xz)/lib" \ @@ -438,11 +438,11 @@ Or, for Python 3.7 through 3.9:: --with-tcltk-libs="$(pkg-config --libs tcl tk)" \ --with-tcltk-includes="$(pkg-config --cflags tcl tk)" -and ``make``:: +And finally, run ``make``:: $ make -s -j2 -or **MacPorts**:: +Alternatively, with **MacPorts**:: $ sudo port install pkgconfig openssl xz gdbm
Or am this patch:
``git format-patch`` output
From 8ae83afc0cbf616c1937408c8e5767ecd4625cf1 Mon Sep 17 00:00:00 2001 From: "C.A.M. Gerlach" <CAM.Gerlach@Gerlach.CAM> Date: Wed, 15 Feb 2023 20:01:14 -0600 Subject: [PATCH] Update following text to match revised macOS building language --- getting-started/setup-building.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/getting-started/setup-building.rst b/getting-started/setup-building.rst index b285a74..15e094a 100644 --- a/getting-started/setup-building.rst +++ b/getting-started/setup-building.rst @@ -419,7 +419,7 @@ For example, with **Homebrew**, install the dependencies:: $ brew install pkg-config openssl@1.1 xz gdbm tcl-tk -Then, for Python 3.10 and newer:: +Then, for Python 3.10 and newer, run ``configure``:: $ CFLAGS="-I$(brew --prefix gdbm)/include -I$(brew --prefix xz)/include" \ LDFLAGS="-L$(brew --prefix gdbm)/lib -I$(brew --prefix xz)/lib" \ @@ -438,11 +438,11 @@ Or, for Python 3.7 through 3.9:: --with-tcltk-libs="$(pkg-config --libs tcl tk)" \ --with-tcltk-includes="$(pkg-config --cflags tcl tk)" -and ``make``:: +And finally, run ``make``:: $ make -s -j2 -or **MacPorts**:: +Alternatively, with **MacPorts**:: $ sudo port install pkgconfig openssl xz gdbm -- 2.37.1.windows.1