◐ Shell
clean mode source ↗

Fix good commit example to use imperative title by DahlitzFlorian · Pull Request #587 · python/devguide

DahlitzFlorian

@DahlitzFlorian

Closes: #577

  • Fix good commit example to use imperative title
  • Explicitly mention the preference for imperative over descriptive titles
  • Link to the article from Chris Beams

@gvanrossum I added the link to the article as suggested by you. The Git Bootcamp is mentioning the article, too, but I agree with you that it is better to explicitly mention it at this point, too.

 
- Fix example to use imperative title
- Explicitly mention the preference for imperative over descriptive titles
- Link to the article from Chris Beams

aeros

@aeros aeros left a comment •

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @DahlitzFlorian. It mostly LGTM; I just have a very minor suggestion.

Since this issue is very well defined and straightforward, I'm good w/ merging it after the suggested changes are made.

@DahlitzFlorian

Thanks for the fast feedback @aeros! I applied your suggestion.

terryjreedy

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve other than one case issue.

 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

@terryjreedy

LGTM. Kyle, leaving this for you if you get to it.

aeros

Co-authored-by: Kyle Stanley <aeros167@gmail.com>

aeros

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the latest changes, LGTM. Thanks for working on this @DahlitzFlorian.

AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request

Jun 17, 2022 
* Explicitly mention the preference for imperative over descriptive titles
* Link to the article from Chris Beams