Release cycle chart: show suggestion if JavaScript disabled by hugovk · Pull Request #997 · python/devguide
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an improvement compared to what we have now, but have you considered creating a static image from mermaid at build time (if possible)? This will make it easier to share/embed too.
have you considered creating a static image from mermaid at build time (if possible)? This will make it easier to share/embed too.
Seems like that could have a number of issues:
- Would need to be regenerated regularly to keep the current date line (and status/colors) accurate and up to date, which is adds complexity and noise
- Less efficient to store in the repo forever every time it is updated, exacerbated by the above
- Would increase bandwidth cost and requests needed to load the page (though probably reduce local CPU load)
- Static embedded rather than inline SVG would not be directly style-able via CSS
- Seems likely to make it more complicated for contributors/RMs to regenerate the image locally, if it requires NodeJS and JavaScript dependencies to be installed
I'm not sure the time, effort and complexity to set up and add to the CI and local workflows is worth it for the tiny proportion of users with JS disabled, but maybe the share/embed use case is more compelling?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, FWIW—too bad we have to rely on raw, but I guess it isn't so bad for the devguide.
