◐ Shell
clean mode source ↗

bpo-45122: Remove PyCode_New from mypyc by corona10 · Pull Request #11067 · python/mypy

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

JelleZijlstra

}

// These functions are basically exactly PyCode_NewEmpty and
// _PyTraceback_Add which are available in all the versions we support.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment still applies to the next function I believe. Not sure what optimization this is talking about.

@gvanrossum

Note that this fixes mypy issue #11066.

JelleZijlstra

97littleleaf11

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gvanrossum

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this waiting for someone or something?

@gvanrossum

Thanks! Now I can sleep at night. :-)

@JelleZijlstra

Always happy to be of service.