◐ Shell
clean mode source ↗

Dark mode: invert some images by hugovk · Pull Request #2409 · python/peps

@encukou

Thank you for implementing this!
As a PEP author (and reader of the sources), I'd appreciate if the class was called e.g. invert-in-dark-mode.

(edited to add:) I work in light mode so the class won't do anything for me. With dark-mode in the name the reason for the class would be obvious.

@hugovk

Thank you for implementing this! As a PEP author (and reader of the sources), I'd appreciate if the class was called e.g. invert-in-dark-mode.

(edited to add:) I work in light mode so the class won't do anything for me. With dark-mode in the name the reason for the class would be obvious.

Updated!

JelleZijlstra

@CAM-Gerlach CAM-Gerlach added the infra

Core infrastructure for building and rendering PEPs

label

Mar 11, 2022

CAM-Gerlach

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (at least per my previous investigation and spot checks of this one). Thanks, @hugovk

@AA-Turner

87a35b1fea as proposed uses pure reST :class: options rather than the .. rst-class extension -- purely an implementation change.

A

@hugovk hugovk deleted the fix-dark-mode-images branch

March 11, 2022 20:42

This was referenced

Apr 28, 2023