Dark mode: invert some images by hugovk · Pull Request #2409 · python/peps
Thank you for implementing this!
As a PEP author (and reader of the sources), I'd appreciate if the class was called e.g. invert-in-dark-mode.
(edited to add:) I work in light mode so the class won't do anything for me. With dark-mode in the name the reason for the class would be obvious.
Thank you for implementing this! As a PEP author (and reader of the sources), I'd appreciate if the class was called e.g.
invert-in-dark-mode.(edited to add:) I work in light mode so the class won't do anything for me. With
dark-modein the name the reason for the class would be obvious.
Updated!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (at least per my previous investigation and spot checks of this one). Thanks, @hugovk
87a35b1fea as proposed uses pure reST :class: options rather than the .. rst-class extension -- purely an implementation change.
A
hugovk
deleted the
fix-dark-mode-images
branch
This was referenced