◐ Shell
clean mode source ↗

Change root url to docs.python.org by StanFromIreland · Pull Request #220 · python/python-docs-theme

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change root url to docs.python.org #220

Changes from all commits

Commits

File filter

Filter by extension

Conversations

Failed to load comments.

Loading

Jump to

Jump to file

Failed to load files.

Loading

Diff view
Diff view

2 changes: 1 addition & 1 deletion python_docs_theme/theme.conf

Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ hosted_on =
issues_url =
license_url =
root_name = Python
root_url = https://www.python.org/
root_url = https://www.docs.python.org/

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the default for every user of this theme. Should we use html_theme_options?

Copy link Copy Markdown

Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, also the link has to be docs.python.org as for some reason it is otherwise broken.

Copy link Copy Markdown

Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also coming back to this option, what do we set the default as?

root_icon = py.svg
root_icon_alt_text = Python logo
root_include_title = True
Expand Down