◐ Shell
clean mode source ↗

Make attributes required on AST type_param classes by jacobtylerwalls · Pull Request #11202 · python/typeshed

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@jacobtylerwalls

Copy link Copy Markdown

Contributor

@github-actions

Copy link Copy Markdown

Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau requested a review from sobolevn

December 28, 2023 12:00

@sobolevn sobolevn left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right. PR was backported to 3.12 as well.

Thank you!

@srittau srittau merged commit 07d1d2a into python:main

Dec 28, 2023

@jacobtylerwalls jacobtylerwalls deleted the ast-type-param-required-attributes branch

December 28, 2023 12:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacobtylerwalls @sobolevn @srittau