Move builtin protocol whitelist to mapping instead of list by YouJiacheng · Pull Request #128 · python/typing_extensions
-
-
Notifications
You must be signed in to change notification settings - Fork 136
Conversation
All commit authors signed the Contributor License Agreement.
blank line contains whitespace Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The added test does indeed fail with the current latest version of typing_extensions on Python 3.7, and this is the fix that was applied in CPython.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters