chore: validate httpx package is not installed by default by lmilbaum · Pull Request #2382 · python-gitlab/python-gitlab
@nejch @JohnVillalovos Is it possible the Test / functional (cli_func_v4)workflow is flaky? This is not the first time my PRs are hitting a similar failure. A rerun usually ends ok.
@nejch @JohnVillalovos Is it possible the
Test / functional (cli_func_v4)workflow is flaky? This is not the first time my PRs are hitting a similar failure. A rerun usually ends ok.
That new test seems to be flaky. Now who is responsible for that? /me checks git blame and sees he wrote it 😳
So looks like I need to spend some more time making test_cancel_merge_when_pipeline_succeeds more reliable. Created issue #2383
Can this be done using tox? So that these tests can be run locally instead of only being able to be done in the CI?
Doesn't have to be a default test that is run in tox but would be good if it can be run locally.
Can this be done using
tox? So that these tests can be run locally instead of only being able to be done in the CI?Doesn't have to be a default test that is run in
toxbut would be good if it can be run locally.
Yup. I forgot to handle it via fox. Thanks for your feedback.
@lmilbaum I probably won't have time to check this until next or the following week. Sorry. Holidays this week in the states and my work is keeping me busy too. I just wanted to let you know that I haven't forgotten.
@nejch Feel free to go ahead without me if it you like it. No need to wait for my approval.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for digging into this @lmilbaum, this took a bit longer than we all expected but will be useful later when we probably use it with some parametrized request clients :)