◐ Shell
clean mode source ↗

Fix numeric keys for dict inputs in tojavascript by hansthen · Pull Request #2100 · python-visualization/folium

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@hansthen

@hansthen hansthen commented

Mar 1, 2025

Copy link Copy Markdown

Collaborator

Even though json cannot have numeric keys in dicts, javascript can. This change handles that case.

Closes #2098

@Conengmo Conengmo left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hans for fixing this. I took the liberty to add a test case.

@hansthen hansthen merged commit 6644d59 into main

Mar 13, 2025

@Conengmo Conengmo deleted the 2098-gradient-parameter-in-heatmap-in-newest-version-cant-work-float-object-has-no-attribute-split branch

March 15, 2025 10:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Conengmo Conengmo Conengmo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Gradient parameter in heatmap in newest version can't work-'float' object has no attribute 'split'

2 participants

@hansthen @Conengmo