CI: run Geopandas tests by Conengmo · Pull Request #2116 · python-visualization/folium
Conversation
Add a workflow to run the Geopandas tests on the dev version of Folium.
Verified this works by pushing a commit to Folium that breaks the Geopandas tests, then restoring it of course.
| - name: Install Geopandas dev dependencies | ||
| run: | | ||
| pip install -r geopandas/requirements-dev.txt | ||
| pip install geodatasets |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martinfleis I was a bit surprised that I had to install geodatasets separately, is that expected? Or did I mis something? I don't mind, just checking.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update requirements-dev. Sorry for that, we're not really using it.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries
CI: run against Geopandas tests
CI: run Geopandas tests
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>