Pybuffer by koubaa · Pull Request #1195 · pythonnet/pythonnet
What does this implement/fix? Explain your changes.
Rebase of https://github.com/pythonnet/pythonnet/pull/980/files
...
Does this close any currently open issues?
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.
@filmor I took this one. After rebasing I just had to bring back a property on the runtime which we removed. It used to be public but I brought it back as internal.
Codecov Report
Merging #1195 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #1195 +/- ## ======================================= Coverage 86.25% 86.25% ======================================= Files 1 1 Lines 291 291 ======================================= Hits 251 251 Misses 40 40
| Flag | Coverage Δ | |
|---|---|---|
| #setup_linux | 64.94% <ø> (ø) |
|
| #setup_windows | 72.50% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update f72a16d...0ed417c. Read the comment docs.
| //"3.0a5+ (py3k:63103M, May 12 2008, 00:53:55) \n[GCC 4.2.3]" | ||
|
|
||
| //we only support python 3 so we just need to check the third character | ||
| return 30 + Convert.ToInt32(versionString[2]); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems very brittle to me, there must be a better solution. Also, we don't support any Python version before 3.5, so checks for that can go.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@filmor I could use sys.version_info but I'd rather not run python code. Let me look for a C API equivalent
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
