Set nativeRegExp to true rather than false. by asajeffrey · Pull Request #210 · servo/rust-mozjs
This repository was archived by the owner on Nov 12, 2022. It is now read-only.
servo / rust-mozjs Public archive
-
Notifications
You must be signed in to change notification settings - Fork 117
Merged
Merged
Conversation
asajeffrey
commented
Nov 3, 2015
asajeffrey
commented
Ms2ger
commented
Nov 3, 2015
Ms2ger commented
Contributor
@bors-servo r+
Thank you for your PR.
bors-servo
commented
Nov 3, 2015
bors-servo commented
Contributor
📌 Commit 0e11a19 has been approved by Ms2ger
bors-servo
commented
Nov 3, 2015
bors-servo commented
Contributor
bors-servo pushed a commit that referenced this pull request
Set nativeRegExp to true rather than false. Improves SpiderMonkey regex performance, and gives us the same default as Firefox. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/210) <!-- Reviewable:end -->
bors-servo
commented
Nov 3, 2015
bors-servo commented
Contributor
☀️ Test successful - travis
bors-servo
merged commit
0e11a19
into
servo:master
bors-servo
commented
Nov 3, 2015
bors-servo commented
Contributor
☔ The latest upstream changes (presumably #210) made this pull request unmergeable. Please resolve the merge conflicts.
asajeffrey
deleted the
native_regexp
branch
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.