◐ Shell
clean mode source ↗

Set nativeRegExp to true rather than false. by asajeffrey · Pull Request #210 · servo/rust-mozjs

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

This repository was archived by the owner on Nov 12, 2022. It is now read-only.

Conversation

@asajeffrey

Copy link Copy Markdown

Improves SpiderMonkey regex performance, and gives us the same default as Firefox.

Review on Reviewable

@Ms2ger

Ms2ger commented

Nov 3, 2015

Copy link Copy Markdown

Contributor

@bors-servo r+

Thank you for your PR.

@bors-servo

Copy link Copy Markdown

Contributor

📌 Commit 0e11a19 has been approved by Ms2ger

@bors-servo

Copy link Copy Markdown

Contributor

⌛ Testing commit 0e11a19 with merge 7cc3064...

bors-servo pushed a commit that referenced this pull request

Nov 3, 2015
Set nativeRegExp to true rather than false.

Improves SpiderMonkey regex performance, and gives us the same default as Firefox.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/210)
<!-- Reviewable:end -->

@bors-servo

Copy link Copy Markdown

Contributor

☀️ Test successful - travis

@bors-servo bors-servo merged commit 0e11a19 into servo:master

Nov 3, 2015

@bors-servo

Copy link Copy Markdown

Contributor

☔ The latest upstream changes (presumably #210) made this pull request unmergeable. Please resolve the merge conflicts.

@asajeffrey asajeffrey deleted the native_regexp branch

November 3, 2015 16:18

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asajeffrey @Ms2ger @bors-servo