Fix leak due to missing free after a host function call. by mjburghard · Pull Request #2 · swiftwasm/JavaScriptKit
swiftwasm / JavaScriptKit Public
-
-
Notifications
You must be signed in to change notification settings - Fork 75
Merged
Merged
Conversation
mjburghard
commented
Mar 15, 2020
mjburghard
commented
Contributor
_prepare_host_function_call calls malloc and returns a pointer which is not freed after the host function call is completed.
kateinoigakukun
approved these changes
kateinoigakukun
left a comment
kateinoigakukun
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me 👍
kateinoigakukun
merged commit
4df1d54
into
swiftwasm:master
mjburghard
deleted the
bugfix/malloc-leak
branch
krodak
mentioned this pull request
krodak
mentioned this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment