Change Data.construct(from uint8Array:) return type from Data? to Data by kateinoigakukun · Pull Request #752 · swiftwasm/JavaScriptKit
-
-
Notifications
You must be signed in to change notification settings - Fork 75
Conversation
Summary
- change
Data.construct(from uint8Array:)return type fromData?toData - keep
Data.construct(from jsValue:)optional, since converting fromJSValuecan fail
Rationale
Constructing from an already-typed JSTypedArray<UInt8> cannot fail, so the optional return type is unnecessary.
Make Data typed-array constructor non-optional
Change Data.construct(from uint8Array:) return type from Data? to Data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 participant
