Fix regex to be NLS_SORT independent by jgebal · Pull Request #1253 · utPLSQL/utPLSQL
-
Notifications
You must be signed in to change notification settings - Fork 187
Merged
Merged
Conversation
jgebal
commented
May 21, 2023
Member
Resolves #1252
Replaced all regexp ranges with posix representations to avoid NLS_SORT impact on regex behavior.
Replaced all regexp ranges with posix representations to avoid NLS_SORT impact on regex behavior.
Contributor
Codecov Report
Patch coverage: 100.00% and project coverage change: +0.01 🎉
Comparison is base (
320b3b0) 94.67% compared to head (962f6fd) 94.69%.
Additional details and impacted files
@@ Coverage Diff @@ ## develop #1253 +/- ## =========================================== + Coverage 94.67% 94.69% +0.01% =========================================== Files 111 111 Lines 5374 5374 Branches 33 33 =========================================== + Hits 5088 5089 +1 Misses 278 278 + Partials 8 7 -1
| Flag | Coverage Δ | |
|---|---|---|
| 11XE | 94.27% <80.00%> (ø) |
|
| 12.1EE | 94.33% <80.00%> (+0.05%) |
⬆️ |
| 18XE | 94.50% <100.00%> (ø) |
|
| 21XE | 94.67% <100.00%> (ø) |
|
| 23free | 94.30% <100.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| source/core/ut_metadata.pkb | 89.88% <ø> (ø) |
|
| source/core/annotations/ut_annotation_manager.pkb | 98.91% <100.00%> (ø) |
|
| source/core/annotations/ut_annotation_parser.pkb | 95.94% <100.00%> (ø) |
|
| source/core/types/ut_executable_test.tpb | 94.28% <100.00%> (ø) |
|
| source/core/ut_expectation_processor.pkb | 100.00% <100.00%> (ø) |
|
| source/core/ut_suite_cache_manager.pkb | 97.01% <100.00%> (ø) |
|
| source/core/ut_suite_manager.pkb | 96.29% <100.00%> (ø) |
|
| source/core/ut_utils.pkb | 94.74% <100.00%> (+0.23%) |
⬆️ |
☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.
sonarqubecloud
Bot
commented
May 21, 2023
sonarqubecloud Bot commented
Kudos, SonarCloud Quality Gate passed!
020150f
into
develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
