◐ Shell
clean mode source ↗

Fix military date parsing not adjusting date by cerdelen · Pull Request #9785 · uutils/coreutils

Conversation

@cerdelen

fixes #9775.

I fixed the bug described in this issue and also added regression tests.

I am pretty sure that the unwrap i added is not okay but i am not sure what fallback date to use if the edgecases of the time is reached and would love for someone to give me some input.

@codspeed-hq

@github-actions

GNU testsuite comparison:

GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?

@github-actions

GNU testsuite comparison:

GNU test failed: tests/tty/tty-eof. tests/tty/tty-eof is passing on 'main'. Maybe you have to rebase?

@github-actions

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

sylvestre

sylvestre

sylvestre

sylvestre

Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>

@github-actions

GNU testsuite comparison:

GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/csplit/csplit-heap is now being skipped but was previously passing.
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

@cerdelen

@sylvestre

@cerdelen could you please update this PR with the test cases from #9798 ?
thanks

sylvestre

@cerdelen

@cerdelen could you please update this PR with the test cases from #9798 ? thanks

line 1117 in file tests/by-util/test_date.rs already tests this explicitly for correct time

and i extended my test with this variation too to checks that the date is correct

@cerdelen

@sylvestre is the 1 failing Pipeline maybe flakey. Its some test with 'more'? So i have to investigate this failed Pipeline or is it okay?

@sylvestre

Don't hesitate to investigate :)
In a different pr

@cerdelen

Is there anything else needed for this PR before it can be merged into the repository?

sylvestre

sylvestre

sylvestre

sylvestre

sylvestre

sylvestre

sylvestre

sylvestre

@cerdelen cerdelen deleted the fix_date_military_parsing branch

January 24, 2026 13:20

2 participants

@cerdelen @sylvestre